Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Shading Relocation Patterns #340

Open
tjcelaya opened this issue Sep 21, 2017 · 0 comments
Open

Consolidate Shading Relocation Patterns #340

tjcelaya opened this issue Sep 21, 2017 · 0 comments

Comments

@tjcelaya
Copy link
Contributor

The idea of "normalizing" shading relocations was brought up by @cburroughs during review of #326. We should consider moving shaded classes to a unified root package to the resulting JAR is easier to work with. This would be a breaking change since it's possible for a user's IDE to autocomplete a class that is shaded, e.g. com.joyent.manta.org.apache.commons.io.IOUtils.

Current relocations:

com.joyent.http       -> com.joyent.manta.http
com.google            -> com.joyent.manta.com.google
org.apache            -> com.joyent.manta.org.apache
com.fasterxml         -> com.joyent.manta.com.fasterxml
io.mikael.urlbuilder  -> com.joyent.manta.io.mikael.urlbuilder
org.objenesis         -> com.joyent.manta.org.objenesis
com.rits              -> com.joyent.manta.com.rits

Proposed relocations:

com.joyent.http       -> com.joyent.manta.shaded.com.joyent.http
com.google            -> com.joyent.manta.shaded.com.google
org.apache            -> com.joyent.manta.shaded.org.apache
com.fasterxml         -> com.joyent.manta.shaded.com.fasterxml
io.mikael.urlbuilder  -> com.joyent.manta.shaded.io.mikael.urlbuilder
org.objenesis         -> com.joyent.manta.shaded.org.objenesis
com.rits              -> com.joyent.manta.shaded.com.rits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant