Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigMBean Allows Configuration Drift from MantaClient #315

Open
tjcelaya opened this issue Aug 17, 2017 · 2 comments
Open

ConfigMBean Allows Configuration Drift from MantaClient #315

tjcelaya opened this issue Aug 17, 2017 · 2 comments
Labels

Comments

@tjcelaya
Copy link
Contributor

While doing some investigation into #311 I noticed we allow editing of quite a few properties through ConfigMBean. As an example of a potential issue, it's currently possible to construct a MantaClient with one manta.key_path value and then change that path to point to a different key without impacting the key actually used for signing requests. A simpler example might be the home value used to list running jobs which is only set on construction of a MantaClient. The expected fix for this issue is at the bare minimum to make the attributes read-only through the MBean but support for tweaking values interactively (like manta.max_connections) and their documentation would be nice.

@tjcelaya tjcelaya added the bug label Aug 17, 2017
@tjcelaya tjcelaya assigned tjcelaya and unassigned tjcelaya Aug 17, 2017
@dekobon
Copy link
Contributor

dekobon commented Aug 29, 2017

Typically, access to MBeans is limited to operators and developers. The only time anyone should be muckering with those values is when doing performance testing. I don't see any problem with changing them to read-only. However, it might be a good way to experiment with a mutable version of a Context.

@cburroughs
Copy link
Contributor

A user might assume that anything implementing SettableConfigContext already is a mutable ConfigContext. Maybe the javadoc should could that? ConfigContextBuilder might have been a name more in line with intended use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants