Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MD5 not validated during MPU commit #300

Open
tjcelaya opened this issue Aug 4, 2017 · 1 comment
Open

MD5 not validated during MPU commit #300

tjcelaya opened this issue Aug 4, 2017 · 1 comment
Assignees
@tjcelaya

Comments

@tjcelaya
Copy link
Contributor

tjcelaya commented Aug 4, 2017 •
edited

The RFD for server-side MPU indicates that the MD5 of the final object content should be returned during commit. It seems like there is no checksumming of the encrypted object content implemented right now.

Some manual testing revealed that the server's response on complete does not include the MD5 either so this might need to be reported upstream as well.
@tjcelaya tjcelaya self-assigned this Aug 4, 2017
@tjcelaya
Copy link
Contributor Author

To clarify: the RFD states that mako-finalize returns the MD5, it says nothing about actually giving it to the user.

A feature request has been logged for this. I'll need to put together a PR for performing a running checksum of the MPU upload as well and can work on that concurrently with the server-side work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjcelaya tjcelaya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tjcelaya