Added loading progress with NJKWebViewProgress #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice integration... How can I change the background color of the progressView? I need them and don't will change the pods-code. For a standalone integration (UIWebView with NJKWebViewProgress) it's very easy. In your integration I don't find any way to change the background color... Please help me. Thanks! |
|
@trainerleipzig now you can't. I see only one way: fork and add progressTintColor property to SVWebViewController.. |
|
+1 |
|
nice |
|
You may also use https://github.com/TimOliver/TOWebViewController in this case. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be nice to add progress to web view, because on slow connection users become confused with white screen without loading indicator.
I added progress like in Safari with NJKWebViewProgress.
I generated workspace for Demo app with CocoaPods, maybe there is better way to add dependency.