Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add executable bit to gradlew #30

Open
wants to merge 2 commits into
base: 1.18.x-architectury
Choose a base branch
from

Conversation

CyberFlameGO
Copy link

removes chmod from workflow

Signed-off-by: Aaron Lowe <cyberflameu@gmail.com>
@LizIsTired
Copy link

This PR is poggers, when Trainguy reviews it, he'll just merge it to every branch although it might be a while until he sees it.

@CyberFlameGO
Copy link
Author

he'll just merge it to every branch

That’s why I made multiple haha; each PR has different branch pairs, and merging one PR to all branches wouldn’t work unfortunately, especially seeing as the workflow file is different across branches.

@LizIsTired
Copy link

The only one that's different is the old branch (current default) that's no longer in development and shouldn't be used, obviously more than welcome to have a separate one for that since it just uses fabric instead of Architectuary. But the others can be cherry picked, so only one for the Architectuary set of branches is necessary :p

@CyberFlameGO
Copy link
Author

Forgot about cherry-picking haha; I’ve closed the other PRs now

@Benjaxdxdxdxdxdxddx
Copy link

where is the link

@CyberFlameGO
Copy link
Author

CyberFlameGO commented Jun 24, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants