🗃️ migrate trips table to use ID instead of IBNR #2422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
… a single modification. (╯°□°)╯︵ ┻━┻
|
"SQLite doesn't support dropping foreign keys (you would need to re-create the table)." (╯°□°)╯︵ ┻━┻ |
MrKrisKrisu
force-pushed
the
dev-ks/2411/hafastrips
branch
from
f43cb6c
to
306f961
Compare
MrKrisKrisu
force-pushed
the
dev-ks/2411/hafastrips
branch
from
306f961
to
bf44ec8
Compare
MrKrisKrisu
changed the title
MrKrisKrisu
force-pushed
the
dev-ks/2411/hafastrips
branch
2 times, most recently
from
4922288
to
631ad15
Compare
MrKrisKrisu
force-pushed
the
dev-ks/2411/hafastrips
branch
from
631ad15
to
dfeb90d
Compare
MrKrisKrisu
changed the title
HerrLevin
requested changes
Mar 21, 2024
| Role::where('name', 'event-moderator')->delete(); | ||
| Role::where('name', 'open-beta')->delete(); | ||
| Role::where('name', 'closed-beta')->delete(); | ||
| // empty now - replaced by PermissionSeeder |
There was a problem hiding this comment.
Hm. Not a fan. Why is this needed?
Also:
- This file should be deleted
- Moving this logic from a migration to a seeder should be a separate PR (imho)
|
|
||
| public function down(): void { | ||
| Permission::findByName('view event history')->delete(); | ||
| // empty now - replaced by PermissionSeeder |
There was a problem hiding this comment.
Hm. Not a fan. Why is this needed?
Also:
- This file should be deleted
- Moving this logic from a migration to a seeder should be a separate PR (imho)
| $permissionCreate->delete(); | ||
| $permissionUpdate->delete(); | ||
| $permissionDelete->delete(); | ||
| // empty now - replaced by PermissionSeeder |
There was a problem hiding this comment.
Hm. Not a fan. Why is this needed?
Also:
- This file should be deleted
- Moving this logic from a migration to a seeder should be a separate PR (imho)
| $roleAdmin->revokePermissionTo($permission); | ||
|
|
||
| $permission->delete(); | ||
| // empty now - replaced by PermissionSeeder |
There was a problem hiding this comment.
Hm. Not a fan. Why is this needed?
Also:
- This file should be deleted
- Moving this logic from a migration to a seeder should be a separate PR (imho)
| Role::findByName('closed-beta')->revokePermissionTo($permission); | ||
|
|
||
| $permission->delete(); | ||
| // empty now - replaced by PermissionSeeder |
There was a problem hiding this comment.
Hm. Not a fan. Why is this needed?
Also:
- This file should be deleted
- Moving this logic from a migration to a seeder should be a separate PR (imho)
database/migrations/2024_03_11_000000_add_origin_and_destination_id_to_trips.php
Show resolved
Hide resolved
HerrLevin
reviewed
Mar 21, 2024
database/migrations/2024_03_11_000000_add_origin_and_destination_id_to_trips.php
Show resolved
Hide resolved
|
@HerrLevin As discussed: I'll split up this PR in multiple small PR's and do separate migrations for create and drop the data for security reasons (data loss). |
|
@MrKrisKrisu Not necessarily multiple PRs but multiple migrations. :) |
# Conflicts: # database/migrations/2023_11_21_000002_add_default_permissions.php # database/migrations/2023_12_17_000003_add_event_history_permission.php # database/migrations/2024_01_29_000000_add_station_permissions.php # database/migrations/2024_01_30_000000_add_activity_permissions.php # database/migrations/2024_02_01_000000_add_permissions_for_manual_trips_beta.php # database/seeders/Constants/PermissionSeeder.php # database/seeders/DatabaseSeeder.php # tests/TestCase.php # update.sh
# Conflicts: # app/Http/Controllers/API/v1/StationController.php # app/Http/Controllers/HafasController.php # app/Models/Trip.php # database/factories/TripFactory.php # database/schema/sqlite-schema.sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2411