feat(hedera): added demo TT file for hedera mainnet network : krypc #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tradetrust-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
isaackps
reviewed
Mar 22, 2024
src/test/endorsement-chain.spec.ts
Outdated
Comment on lines
71
to
82
| // await t.expect(EndorsementChainAddressMinter.count).eql(4); | ||
| // await t.expect(EndorsementChainAddress1.count).eql(4); | ||
| // await t.expect(EndorsementChainAddress2.count).eql(2); | ||
| // | ||
| // await t.expect(DocumentIssuedAction.count).eql(1); | ||
| // | ||
| // await t.expect(EndorseNomineeAction.count).eql(1); | ||
| // await t.expect(ChangeOwnershipAction.count).eql(1); | ||
| // await t.expect(TransferHoldershipAction.count).eql(1); | ||
| // | ||
| // await t.expect(SurrenderToIssuerAction.count).eql(1); | ||
| // await t.expect(SurrenderAcceptedAction.count).eql(1); |
There was a problem hiding this comment.
why are all these test commented out?
There was a problem hiding this comment.
because of this issue
There was a problem hiding this comment.
it should be the RPC url that was used. can use 1 that can be queried and it should be using an archived node
👷 Deploy request for reference-implementation pending review.Visit the deploys page to approve it
|
|
We updated RPC Url in configuration. Tested locally and attached screenshot also @isaackps
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added demo TT file for hedera mainnet network
Updated test cases