fix: alchemy keys #801
Open
fix: alchemy keys #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simboonlong
commented
Jul 31, 2023
•
simboonlong
commented
- as per introduced since.
- only used in querying fixtures in integration tests.
- this pr cleans up the alchemy keys used. free tier gives 300 million compute units.
- 1 run as of today on this pr consumes around 38 requests, 1140 compute units.
✅ Deploy Preview for tradetrust-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
superical
approved these changes
Jul 31, 2023
| @@ -18,7 +18,7 @@ module.exports = { | |||
| }, | |||
| INFURA_API_KEY: process.env.INFURA_API_KEY || "bb46da3f80e040e8ab73c0a9ff365d18", | |||
| INFURA_PROJECT_ID: "1f1ff2b3fca04f8d99f67d465c59e4ef", | |||
| ALCHEMY_API_KEY: process.env.ALCHEMY_API_KEY || "pV9JmoYcDFFBihXlJWt6FSDxzNAVWxdT", | |||
| ALCHEMY_API_KEY: process.env.ALCHEMY_API_KEY || "483Uqp_0SP0NnXI0secbJgrSRXv4OXaj", | |||
There was a problem hiding this comment.
Just curious only, is any part of our frontend now uses the Alchemy API key instead of the Infura one?
There was a problem hiding this comment.
none at all. i can only assume it was to help those **.integration.test.ts tests be more stable
There was a problem hiding this comment.
No strong opinions about it, though, I’d be curious if there is a reason for using Alchemy for integration testing only but Infura for the actual functionalities?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.