Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a DBConnector class #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sqlchow
Copy link

@sqlchow sqlchow commented Oct 4, 2014

This was a class I wrote few weeks back, when I was trying to create a DBConnectionFactory. Most of the code in the class has been gleaned from various sources on the internet.

Most of the code works as I have tried connecting to various sources (sql server & odbc) using this class.

This was a class I wrote few weeks back, when I was trying to create a
DBConnectionFactory. Most of the code in the class has been gleaned from
various sources on the internet.
@zippy1981
Copy link
Member

Obviously it's Matans project so I reserve final judgement with him.

However, you should connect the rest of the code to this class before submitting a pull request. You can move it to a different branch for now if you want feedback on the WIP.

@sqlchow
Copy link
Author

sqlchow commented Oct 4, 2014

I will try connecting the rest of the code to this class. But, how do I move it to a different branch for getting feedback on the class? Just cancel the pull and create a new branch?

@zippy1981
Copy link
Member

Yes make a new branch. Open an issue and reference it in an issue if you
want feedback.
On Oct 4, 2014 10:17 AM, "sqlchow" notifications@github.com wrote:

I will try connecting the rest of the code to this class. But, how do I
move it to a different branch for getting feedback on the class? Just
cancel the pull and create a new branch?


Reply to this email directly or view it on GitHub
#3 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants