-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type fragment inputs (for dict editor) despite errors #5983
base: staging
Are you sure you want to change the base?
Conversation
created: #5985 |
(nondeterministic cypress error) |
if possible, this could also go into release/1.15 |
designer/server/src/test/scala/pl/touk/nussknacker/ui/integration/DictsFlowTest.scala
Outdated
Show resolved
Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/integration/DictsFlowTest.scala
Outdated
Show resolved
Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/integration/DictsFlowTest.scala
Outdated
Show resolved
Hide resolved
) | ||
|
||
val globalErrorProcess = extractGlobalValidationResult(process) | ||
globalErrorProcess.map(_.error.typ) shouldBe List("InvalidTailOfBranch") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error type looks hacky in this context. I'd rather expect sth like output of fragment is not used or sth similar. Is it easy to change? Can it be node error instead of global error?
|}""".stripMargin | ||
|
||
val globalErrorFrag = extractGlobalValidationResult(fragmentName, fragmentJson) | ||
globalErrorFrag.map(_.error.typ) shouldBe List("InvalidTailOfBranch") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error type looks hacky in this context. I'd rather expect sth like usage of/reference to invalid fragment . Is it easy to change? Can it be node error instead of global error?
Describe your changes
This allows the fragment to be typed (e.g. for the purpose of DictParameterEditor / substitotor), if:
Checklist before merge