Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1479] newdeployment.DeploymentService rewrite #5982

Merged
merged 7 commits into from
May 29, 2024

Conversation

arkadius
Copy link
Member

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@arkadius arkadius force-pushed the NU-1479-deployment-status-endpoint-rewrite branch 3 times, most recently from a549f81 to e3a2007 Compare April 26, 2024 15:27
@arkadius arkadius force-pushed the NU-1479-deployment-status-endpoint-rewrite branch from e3a2007 to 23d6b48 Compare May 6, 2024 15:17
Copy link
Contributor

github-actions bot commented May 6, 2024

created: #6110
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@arkadius arkadius force-pushed the NU-1479-deployment-status-endpoint-rewrite branch 6 times, most recently from e09a280 to dccf5d5 Compare May 8, 2024 20:38
@arkadius arkadius force-pushed the NU-1479-deployment-status-endpoint-rewrite branch from dccf5d5 to 90a9a0e Compare May 20, 2024 07:15
@arkadius arkadius force-pushed the NU-1479-deployment-status-endpoint-rewrite branch 2 times, most recently from 0d5364b to 6033822 Compare May 21, 2024 13:41
@github-actions github-actions bot added the docs label May 21, 2024
@arkadius arkadius changed the title Nu 1479 deployment status endpoint rewrite [NU-1479] newdeployment.DeploymentService rewrite May 21, 2024
@arkadius arkadius force-pushed the NU-1479-deployment-status-endpoint-rewrite branch from 6033822 to 1d335eb Compare May 21, 2024 14:29
@arkadius arkadius marked this pull request as ready for review May 21, 2024 14:52
@arkadius arkadius force-pushed the NU-1479-deployment-status-endpoint-rewrite branch from 1d335eb to 3cb3a5d Compare May 21, 2024 15:03
@github-actions github-actions bot removed the docs label May 21, 2024
@arkadius arkadius force-pushed the NU-1479-deployment-status-endpoint-rewrite branch from 3cb3a5d to 5e8932b Compare May 21, 2024 15:07
@github-actions github-actions bot added the docs label May 28, 2024
@arkadius arkadius enabled auto-merge (squash) May 29, 2024 08:22
@arkadius arkadius merged commit 8ebf102 into staging May 29, 2024
19 checks passed
@arkadius arkadius deleted the NU-1479-deployment-status-endpoint-rewrite branch May 29, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants