Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghidra 10.3 support #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

antipatico
Copy link

The template for the help file changed and trying to compile the project for ghidra version 10.3 will throw the following error:

Welcome to Gradle 7.3!

Here are the highlights of this release:
 - Easily declare new test suites in Java projects
 - Support for Java 17
 - Support for Scala 3

For more details see https://docs.gradle.org/7.3/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

> Task :compileJava
Note: /REDACTED/ghidra-findcrypt/FindCrypt/src/main/java/findcrypt/FindCryptAnalyzer.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :buildHelp FAILED
INFO  Using log config file: jar:file:/REDACTED/ghidra_10.3_PUBLIC/Ghidra/Framework/Generic/lib/Generic.jar!/generic.log4j.xml (LoggingInitialization)  
INFO  Using log file: /REDACTED/.helpbuilder/.helpbuilder_0.1_NO_RELEASE/application.log (LoggingInitialization)  
Exception in thread "main" ghidra.util.exception.AssertException: Errors parsing HTML file: help.html
Incorrect stylesheet defined - none match help/shared/DefaultStyle.css in file /REDACTED/ghidra-findcrypt/FindCrypt/src/main/help/help/topics/findcrypt/help.html
        Discovered stylesheets: [/REDACTED/ghidra-findcrypt/FindCrypt/src/main/help/help/shared/Frontpage.css]

        at help.validator.model.HelpFile.parseLinks(HelpFile.java:106)
        at help.validator.model.HelpFile.<init>(HelpFile.java:43)
        at help.validator.model.HelpTopic$1.visitFile(HelpTopic.java:85)
        at help.validator.model.HelpTopic$1.visitFile(HelpTopic.java:71)
        at java.base/java.nio.file.Files.walkFileTree(Files.java:2811)
        at java.base/java.nio.file.Files.walkFileTree(Files.java:2882)
        at help.validator.model.HelpTopic.loadHelpFiles(HelpTopic.java:71)
        at help.validator.model.HelpTopic.<init>(HelpTopic.java:56)
        at help.validator.location.HelpModuleLocation.loadHelpTopics(HelpModuleLocation.java:62)
        at help.validator.location.HelpModuleLocation.<init>(HelpModuleLocation.java:41)
        at help.validator.location.DirectoryHelpModuleLocation.<init>(DirectoryHelpModuleLocation.java:29)
        at help.HelpBuildUtils.toLocation(HelpBuildUtils.java:68)
        at help.validator.location.HelpModuleCollection.toHelpLocations(HelpModuleCollection.java:95)
        at help.validator.location.HelpModuleCollection.fromFiles(HelpModuleCollection.java:79)
        at help.GHelpBuilder.collectAllHelp(GHelpBuilder.java:115)
        at help.GHelpBuilder.build(GHelpBuilder.java:89)
        at help.GHelpBuilder.main(GHelpBuilder.java:83)

This merge requests fixes that by adapting to the current standard of ghidra 10.3, which is instead of shipping Frongpage.css, the extensions now shall use the default DefaultStyle.css.

@antoniovazquezblanco
Copy link

I've started to maintain my branch in order to have up to date builds: https://github.com/antoniovazquezblanco/ghidra-findcrypt/releases

@bvernoux
Copy link

I confirm those fix also work for Ghidra 10.4
@TorgoTorgo Could you merge it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants