BWEnv: Log to /tmp/tc_data on non-Windows platforms #219
Conversation
| @@ -40,12 +40,20 @@ void ConfigManager::loadDefault() | |||
| void ConfigManager::loadGeneralSection() | |||
| { | |||
| port = readInt_("general", "port", 0); | |||
| #ifdef _WIN32 | |||
| log_path = readString_("general", "log_path", "C:/tc_data/torchcraft_log_cpp_port_"); | |||
There was a problem hiding this comment.
Maybe %SystemDrive% instead of C: (same below)
There was a problem hiding this comment.
Forgive my ignorance, but will Windows automatically expand this to e.g. C:/, or does this require some environment variable lookup?
There was a problem hiding this comment.
I'm pretty confident the replacement is handled at the OS level. For example, this works:
There was a problem hiding this comment.
I'm not so sure -- I can do ls ~ as well but that doesn't mean I can use it like that when opening a std::ifstream (right?) as there's no shell expansion happening. Anyway, will try it since information about this seems hard to find online.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This is a quick fix to ease debugging on non-Windows platforms.