Feature: Validate primary key presence in bulk upload and autogenerate value of serial data type column #9403

parthy007 · 2024-04-17T05:07:02Z

* update PDF component * merged with develop and added changes to the new version

Fix : table creation datatype dropdown is overlapping

…roxy don't support `ws` connections (#9128) * updated package.json * removed socket check from the release button * Changed web-socket connection to Singleton class * reverted unwanted changes * Refactored the code. added appId check too

* Extended chart support on chart component * render fix * Bumped version and fixed eslint error --------- Co-authored-by: Adish M <adish.madhu@gmail.com>

[docs]: Add method to set default language

Main to develop merge

* Immport higher version issue * Fix: import higher version * toast error meassage * typo fix * toast error message --------- Co-authored-by: Kritagya <kriks.iitk@.com>

* bump version * copywrite update (#9075) * Import higher version fix (#8922) * Immport higher version issue * Fix: import higher version * toast error meassage * typo fix * toast error message --------- Co-authored-by: Kritagya <kriks.iitk@.com> * fix toggles on workspace login page (#9150) * fix: drag and drop on bulk upload (#9143) * Added fix for create organization key-down issue (#9151) --------- Co-authored-by: Anantshree Chandola <anantshreechandola23@gmail.com> Co-authored-by: kriks7iitk <34170719+kriks7iitk@users.noreply.github.com> Co-authored-by: Kritagya <kriks.iitk@.com> Co-authored-by: vjaris42 <vjy239@gmail.com> Co-authored-by: Muhsin Shah C P <muhsinshah21@gmail.com>

Merge main to develop

…etting started and tooljet concepts (#9158)

…compatibility as cloning is only possible from the same tj version (#9154) * fixes: on cloning apps should not transform the data or do backward compatibility as cloning is only possible from the same tj version --------- Co-authored-by: arpitnath <arpitnath42@gmail.com>

Fix read documentation button for marketplace plugins

* unify runpy execution for query and transformations * fix python execution result on transformation * bump to v2.33.5

[docs]: Fix sidebar link for aws lambda

Merge main to develop

* updated the screenshots * reduced the gif size * reverted the package.json file * edited the zoomed in images and replaced some gifs with screenshots * removed one gif * update static media * update file names * update toolbar * fix file names * fix: dynamodb img path * update media for org management dashboard * fix: casing and formatting * update workspace constant media * update media in workspace settings and github * update github sso * minor change to github sso docs * minor fix * update google sso * change includeCurrentVersion flag to false --------- Co-authored-by: Asjad Ahmed Khan <iitasjad2001@gmail.com> Co-authored-by: Asjad Ahmed Khan <60435499+2001asjad@users.noreply.github.com> Co-authored-by: Karan Rathod <karan.altcampus@gmail.com>

Merge main to develop

[docs]: Fix typo

Correction in docker release slack notification

Merge branch 'feature/tjdb-create-primarykey' into feature/bulkUpload-primary-key

socket-security · 2024-04-17T05:44:59Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@docusaurus/core@2.0.0-alpha.73	Transitive: environment, eval, filesystem, network, shell, unsafe	`+333`	23.9 MB	slorber
npm/@docusaurus/plugin-google-gtag@2.0.0-alpha.73	environment	`0`	5.15 kB	slorber
npm/@docusaurus/preset-classic@2.0.0-alpha.73	environment Transitive: eval, filesystem, network, shell, unsafe	`+180`	19.5 MB	slorber
npm/@mdx-js/react@1.6.22	None	`0`	15.5 kB	johno
npm/clsx@1.1.1	None	`0`	6.28 kB	lukeed
npm/minio@7.1.3	filesystem, network Transitive: environment, eval	`+45`	13.9 MB	minio

🚮 Removed packages: npm/@babel/core@7.23.5, npm/@babel/eslint-parser@7.23.3, npm/@babel/plugin-transform-runtime@7.23.4, npm/@babel/preset-env@7.23.5, npm/@babel/preset-react@7.23.3, npm/@dnd-kit/core@6.1.0, npm/@dnd-kit/sortable@7.0.2, npm/@dnd-kit/utilities@3.2.2, npm/@emoji-mart/data@1.1.2, npm/@emoji-mart/react@1.1.1, npm/@radix-ui/colors@0.1.9, npm/@radix-ui/react-popover@1.0.7, npm/@radix-ui/react-slider@1.1.2, npm/@radix-ui/react-toggle-group@1.0.4, npm/@react-google-maps/api@2.19.2, npm/@rollup/plugin-commonjs@21.1.0, npm/@rollup/plugin-node-resolve@13.3.0, npm/@sentry/react@7.100.1, npm/@sentry/tracing@7.100.1, npm/@sentry/webpack-plugin@2.14.0, npm/@storybook/addon-essentials@7.6.3, npm/@storybook/addon-interactions@7.6.3, npm/@storybook/addon-links@7.6.3, npm/@storybook/addon-onboarding@1.0.9, npm/@storybook/blocks@7.6.3, npm/@storybook/react-webpack5@7.6.3, npm/@storybook/react@7.6.3, npm/@storybook/testing-library@0.2.2, npm/@svgr/webpack@6.5.1, npm/@tabler/icons-react@2.42.0, npm/@testing-library/jest-dom@5.17.0, npm/@testing-library/react@13.4.0, npm/@testing-library/user-event@14.5.1, npm/@types/assert@1.5.10, npm/@types/emscripten@1.39.10, npm/@types/expect@24.3.0, npm/@types/mocha@9.1.1, npm/@types/node-fetch@2.6.9, npm/@types/ws@8.5.10, npm/@uiw/react-codemirror@3.2.10, npm/@y-presence/react@2.0.1, npm/base-64@1.0.0, npm/chai-as-promised@7.1.1, npm/chai@4.4.1, npm/cross-env@7.0.3, npm/dts-bundle-generator@6.13.0, npm/mocha@9.2.2, npm/npm-run-all@4.1.5, npm/nyc@15.1.0, npm/rollup-plugin-terser@7.0.2, npm/rollup-plugin-ts@2.0.7, npm/rollup@2.79.1, npm/ts-mocha@9.0.2, npm/tsd@0.24.1, npm/typedoc@0.22.18, npm/typescript@4.9.5, npm/ws@8.16.0

View full report↗︎

socket-security · 2024-04-17T05:45:02Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source
Install scripts	npm/core-js-pure@3.18.3	Install script: postinstall Source: `node -e "try{require('./postinstall')}catch(e){}"`	`docs/versioned_docs/version-2.12.0/widgets/package-lock.json`
Install scripts	npm/core-js@3.18.3	Install script: postinstall Source: `node -e "try{require('./postinstall')}catch(e){}"`	`docs/versioned_docs/version-2.12.0/widgets/package-lock.json`

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/core-js-pure@3.18.3
@SocketSecurity ignore npm/core-js@3.18.3

github-actions · 2024-04-18T06:04:09Z

Deployment: https://tooljet-pr-9403.onrender.com
Dashboard: https://dashboard.render.com/web/srv-cogbflcf7o1s73fr1260

akshaysasidrn · 2024-04-18T06:23:05Z

server/src/services/tooljet_db_bulk_upload.service.ts

+
+        const { keytype, data_type } = columnDetails;
+
+        if (keytype === 'PRIMARY KEY' && data_type !== 'serial') {


I don't think we get data_type as serial explicitly. We might have to look at the default value and infer that it is of serial type. [related]

server/src/services/tooljet_db_bulk_upload.service.ts

karan-rathod-316 and others added 30 commits March 18, 2024 13:01

[docs]: Update PDF component (#9088)

c818964

* update PDF component * merged with develop and added changes to the new version

update docs favicon: (#9118)

bb4df15

[docs] SSO revamp (#9031)

96de3ca

fix : while table create datatype dropdown is overlapping

fc297be

Merge pull request #9132 from ToolJet/fix/dropdown-overlap

7b79916

Fix : table creation datatype dropdown is overlapping

add method to set default language

7f6f9c1

feat: Extended chart support on chart component (#8912)

9b3af0c

* Extended chart support on chart component * render fix * Bumped version and fixed eslint error --------- Co-authored-by: Adish M <adish.madhu@gmail.com>

Merge pull request #9137 from ToolJet/docs/update-localization-info

4ddb912

[docs]: Add method to set default language

Merge branch 'main' into main-to-develop-merge

6b2d82d

Merge pull request #9140 from ToolJet/main-to-develop-merge

5601216

Main to develop merge

Merge branch 'develop' into release/database-1.1

a6c1da8

bump version

12fc634

copywrite update (#9075)

d24baaa

Import higher version fix (#8922)

b0113c5

* Immport higher version issue * Fix: import higher version * toast error meassage * typo fix * toast error message --------- Co-authored-by: Kritagya <kriks.iitk@.com>

fix toggles on workspace login page (#9150)

148431b

fix: drag and drop on bulk upload (#9143)

64e24cf

Added fix for create organization key-down issue (#9151)

d17561a

Merge pull request #9157 from ToolJet/main

c123b59

Merge main to develop

update image settings through custom css and update screenshots for g…

c2d8689

…etting started and tooljet concepts (#9158)

fix read documentation button

6d35ef6

fix formatting for setup icons (#9172)

f88f397

Merge pull request #9170 from ToolJet/docs/fix-read-documentation-button

e3790c3

Fix read documentation button for marketplace plugins

Hotfix: Unify runpy execution for query and transformations (#8999)

1cbe428

* unify runpy execution for query and transformations * fix python execution result on transformation * bump to v2.33.5

fix sidebar link for aws lambda

5753efc

Merge pull request #9195 from ToolJet/docs/fix-sidebar-id

7263469

[docs]: Fix sidebar link for aws lambda

Merge pull request #9193 from ToolJet/main

97187cb

Merge main to develop

akshaysasidrn and others added 10 commits April 12, 2024 14:29

fix marketplace dependencies build (#9360)

380d662

Merge pull request #9364 from ToolJet/main

12da3fb

Merge main to develop

Fix typo

a9ddcc3

Merge pull request #9375 from prathamesh-sonpatki/patch-1

e9bf121

[docs]: Fix typo

Correction in docker release slack notification

7d830f7

Merge pull request #9379 from ToolJet/fix/slack-notification

47d7e8a

Correction in docker release slack notification

Merge branch 'develop' into release/database-1.1

43823bb

Merge primary-key feature for other columns in TJDB dashboard

7635ccf

Merge branch 'feature/tjdb-create-primarykey' into feature/bulkUpload-primary-key

Merging new changes

54c9ef4

Merge branch 'feature/tjdb-create-primarykey' into feature/bulkUpload-primary-key

Make primary key data mandatory except for serial data type

75691b5

akshaysasidrn changed the base branch from develop to release/database-1.1 April 17, 2024 05:36

akshaysasidrn changed the base branch from release/database-1.1 to feature/tjdb-create-primarykey April 17, 2024 05:36

Remove unnecessary console.log and comments

3d171ce

parthy007 changed the title ~~Feature: Validate Primary Key Presence in Bulk CSV Upload & Autogenerate value of serial data type column~~ Feature: Validate Primary Key Presence in Bulk CSV Upload and autogenerate value of serial data type column Apr 17, 2024

parthy007 changed the title ~~Feature: Validate Primary Key Presence in Bulk CSV Upload and autogenerate value of serial data type column~~ Feature: Validate primary key presence in bulk upload and autogenerate value of serial data type column Apr 17, 2024

akshaysasidrn added the create-review-app label Apr 18, 2024

github-actions bot added active-review-app and removed create-review-app labels Apr 18, 2024

akshaysasidrn reviewed Apr 18, 2024

View reviewed changes

Detect serial datatype against int datatype

3c91acb

akshaysasidrn reviewed Apr 18, 2024

View reviewed changes

server/src/services/tooljet_db_bulk_upload.service.ts Outdated Show resolved Hide resolved

add ability to upsert rows on conflicting pk

646535c

akshaysasidrn added the suspend-review-app label Apr 20, 2024

github-actions bot removed the active-review-app label Apr 20, 2024

akshaysasidrn closed this Apr 25, 2024

github-actions bot removed the suspend-review-app label Apr 25, 2024

akshaysasidrn deleted the feature/bulkUpload-primary-key branch April 25, 2024 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Validate primary key presence in bulk upload and autogenerate value of serial data type column #9403

Feature: Validate primary key presence in bulk upload and autogenerate value of serial data type column #9403

parthy007 commented Apr 17, 2024

socket-security bot commented Apr 17, 2024 •

edited

socket-security bot commented Apr 17, 2024 •

edited

github-actions bot commented Apr 18, 2024

akshaysasidrn Apr 18, 2024


		const { keytype, data_type } = columnDetails;

		if (keytype === 'PRIMARY KEY' && data_type !== 'serial') {

Feature: Validate primary key presence in bulk upload and autogenerate value of serial data type column #9403

Feature: Validate primary key presence in bulk upload and autogenerate value of serial data type column #9403

Conversation

parthy007 commented Apr 17, 2024

socket-security bot commented Apr 17, 2024 • edited

socket-security bot commented Apr 17, 2024 • edited

Next steps

github-actions bot commented Apr 18, 2024

akshaysasidrn Apr 18, 2024

Choose a reason for hiding this comment

socket-security bot commented Apr 17, 2024 •

edited

socket-security bot commented Apr 17, 2024 •

edited