Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add quote to seed values #56

Merged
merged 1 commit into from Nov 28, 2022
Merged

Conversation

alexezio
Copy link

@alexezio alexezio commented Nov 23, 2022

hello teams:
I find a issue related to helm install.
when you set the value of tonicStatisticsSeed to a large numeric. helm try to cast it to float64. see details below:

[2022-11-22T10:45:12+00:00 ERR Allos.Api] Error on web server startup
Allos.Core.Exceptions.TonicException: Failed to parse TONIC_STATISTICS_SEED VALUE. Must be an integer value, got: '5.837265e+06'

MyValue: 5837265
ActualValue: 5.837265e+06

this issue still pending to fix, so I add the quoted string to this variables.
you can go through this issue by: helm/helm#1707

@alexezio
Copy link
Author

@calexander3 could you please review this pr?

@calexander3 calexander3 merged commit c57ab32 into TonicAI:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants