Add user_agent parameter when instantiating classes (and fix examples)
#85
+42
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Nominatim Usage Policy requires the application to be identified in HTTP requests. In this context, TkinterMapView is not the application; it is a library. Calling applications need to pass a User-Agent string.
|
In the case of my team, this has now become a problem because some user of this library has spammed the search API and it seems to have temporarily banned the user agent. I'd like to see this in a future release of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nominatim Usage Policy requires the application to be identified in HTTP requests. In this context, TkinterMapView is not the application; it is a library. Calling applications need to pass a User-Agent string. (Notice the corresponding documentation for
geopy.)This adds a unique
User-Agentto each example. (Additionally, fix the window title in several examples, and make theimportstatements consistent.)