Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin kerchunk (set floor) and enable Python 3.12 #108

Merged
merged 2 commits into from
May 10, 2024

Conversation

jsignell
Copy link
Contributor

@jsignell jsignell commented May 10, 2024

Closes #77

Given that fsspec/kerchunk#445 seems to be resolved on main. This PR unpins the kerchunk version and uses the unreleased version newly released 0.2.5 instead. To me it seems fair that this library would sometimes require unreleased kerchunk and that feels preferable to pinning down to an old release.

@TomNicholas
Copy link
Owner

TomNicholas commented May 10, 2024

Thanks for spotting that kerchunk has fixed that bug @jsignell !

I'm hesitant to pin this package to kerchunk main because I would like the reliability of knowing we are pinning to a released version... If stuff like this can be fixed on kerchunk main without notice it could also get broken...

EDIT: Ideally kerchunk would release and then we pin to that.

@jsignell
Copy link
Contributor Author

To be fair it was already fixed on main when the original ticket was opened. But yeah I see the hesitation. Let's ask for a kerchunk release :)

@jsignell
Copy link
Contributor Author

fsspec/kerchunk#457

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (f226093) to head (36dfb7b).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   90.18%   90.73%   +0.55%     
==========================================
  Files          14       18       +4     
  Lines         998     1144     +146     
==========================================
+ Hits          900     1038     +138     
- Misses         98      106       +8     
Flag Coverage Δ
unittests 90.73% <ø> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsignell jsignell changed the title Unpin kerchunk (use main) and enable Python 3.12 Unpin kerchunk (set floor) and enable Python 3.12 May 10, 2024
@TomNicholas TomNicholas merged commit 21c4884 into TomNicholas:main May 10, 2024
7 of 8 checks passed
@jsignell jsignell deleted the unpin-kerchunk branch May 10, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin kerchunk==0.2.2 and add python 3.12 back to CI test matrix
2 participants