Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorchooser improvements #78

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

rdbende
Copy link
Member

@rdbende rdbende commented Mar 24, 2021

Just some simple improvement for the ColorPicker:

  • DE, HU translation
  • relief improvements (tk.SOLID)
  • preset-color ordering in functions.py
  • single and double quote correction

image

An entry that takes only numbers or calculations and calculates the result of the calculation
Change the default hover-cursor from hand1 to hand2
Change the movement cursor from exchange to fleur
Change the default cursor to use the native link pointer on Mac and Windows
Add __getitem__, __setitem__, config and configure, docstring formatting
I would consider replacing this entire widget with a ttk.Spinbox.
Unfortunately, it doesn't change much on Linux, but it would look better on Windows and Mac anyway.
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #78 (ef832b2) into master (9145d17) will decrease coverage by 0.05%.
The diff coverage is 94.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   89.31%   89.25%   -0.06%     
==========================================
  Files          43       42       -1     
  Lines        4032     4030       -2     
==========================================
- Hits         3601     3597       -4     
- Misses        431      433       +2     
Impacted Files Coverage Δ
ttkwidgets/color/colorpicker.py 96.34% <92.70%> (-0.45%) ⬇️
ttkwidgets/color/alphabar.py 95.12% <100.00%> (ø)
ttkwidgets/color/colorsquare.py 97.05% <100.00%> (ø)
ttkwidgets/color/functions.py 96.22% <100.00%> (ø)
ttkwidgets/color/gradientbar.py 94.20% <100.00%> (ø)
ttkwidgets/color/spinbox.py 96.61% <100.00%> (ø)
ttkwidgets/validated_entries/numbers.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9145d17...ef832b2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant