Update to TileDB-2.21.0 and add support for the TILEDB_GEOM_* types: #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
changed the title
TILEDB_GEOM_WKB and TILEDB_GEOM_WKB:TILEDB_GEOM_WKB and TILEDB_GEOM_WKB:
DimitrisStaratzis
force-pushed
the
dstara/fix_issue_310
branch
from
1de2e6f
to
160a99d
Compare
DimitrisStaratzis
changed the title
TILEDB_GEOM_WKB and TILEDB_GEOM_WKB:TILEDB_GEOM_* types:
DimitrisStaratzis
changed the title
TILEDB_GEOM_* types:TILEDB_GEOM_* types:
DimitrisStaratzis
changed the title
TILEDB_GEOM_* types:TILEDB_GEOM_ types:
DimitrisStaratzis
changed the title
TILEDB_GEOM_ types:
ihnorton
approved these changes
Mar 21, 2024
|
Thanks! The geometry push down shouldn't be affected by the new types since we don't reference the geometry attribute directly; the spatial indexing happens on the integer dimensions and the geometry itself is treated as an opaque payload. That said, I owe you some tests to confirm, but it should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.