Simplify workflow. #300
Merged
Simplify workflow. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous PR #292 introduced a file that contains shared variables. It's more idiomatic to put these variables directly into the workflow, using the `env` variable.
snagles
approved these changes
Mar 15, 2024
Shelnutt2
reviewed
Mar 16, 2024
| @@ -7,6 +7,12 @@ on: | |||
| pull_request: | |||
| branches: [ master ] | |||
|
|
|||
| env: | |||
| # The version of TileDB to test against. | |||
| CORE_VERSION: "2.20.1" | |||
There was a problem hiding this comment.
I find these names more descriptive than what I used before, and got inspired by Paul's unmerged PR #231.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR #292 introduced a file that contains shared variables. It's more idiomatic to put these variables directly into the workflow, using the
envvariable.