New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap tiledb_handle_load_array_schema_request #277
base: master
Are you sure you want to change the base?
Conversation
This pull request has been linked to Shortcut Story #35285: Submit TileDB-Go PR to wrap tiledb_handle_load_array_schema_request. |
Some of those test failures look like version incompatibilities and I can't decipher the others. I'm no Go expert so feel free to poke me with a clue stick if I've missed anything obvious. Also, I believe this is the first ever Go PR I've ever submitted which is very exciting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'll leave for @anastasop to get a second set of eyes on the Go code, and merge.
@davisp the PR is OK. The tests fail because it is build against a TileDB 2.17.4 build. To eliminate the test failures you can cherry-pick the |
This wraps the new tiledb_handle_load_array_schema_request function in TileDB.
68869dc
to
bd45631
Compare
This wraps the new tiledb_handle_load_array_schema_request function in TileDB.
I was a bit unsure of where to put this. But based on the prior art for
DeserializeLoadEnumerationsRequest
, I stuck it inarray_schema.go
.There's also at least one more of these coming for another handler though. So if you want me to create a new
handlers.go
orcloud_handlers.go
or some such, I could also move the Enumeration handler and add the third all in one PR if that's preferable.Also, I have no idea on Go style guides. I just know that this compiles. When I run
go fmt
locally it changes a lot of things that do not appear as they should changed so I've not run it and am just crossing my fingers I aped theDeserializeLoadEnumerationsRequest
code closely enough.