Update Group Info. #536
Merged
Update Group Info. #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snagles
approved these changes
Mar 14, 2024
Shelnutt2
reviewed
Mar 18, 2024
| time.sleep(1) | ||
| self.fail(f"group {self.namespace}/{name} still exists") | ||
| description = "this is a test description" | ||
| logo = "testLogo" |
There was a problem hiding this comment.
Logo is expected to be a base64 encoded image. If you are looking for a test to validate it end to end perhaps we should hardcode an image value?
There was a problem hiding this comment.
That would be better, although a string value would pass just the same
Shelnutt2
reviewed
Mar 19, 2024
| self.assertCountEqual(group_info.tags, tags) | ||
|
|
||
| # Cleanup | ||
| groups.deregister(group_uri) |
There was a problem hiding this comment.
I think we should delete not just deregister so we cleanup storage too.
There was a problem hiding this comment.
I have just copied the "delete"/deregister from the existing test.
It has a TODO about that same issue.
Do we have a real delete method @Shelnutt2?
ihnorton
requested review from
thetorpedodog
and removed request for
thetorpedodog
JohnMoutafis
deleted the
johnmoutafis/add-update-info-to-tiledb-cloud-groups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK to allow Group Info updating, using the v2 of the API.