Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests and Integration Tests #47

Open
marc-antoine-girard opened this issue Jul 26, 2022 · 2 comments
Open

Unit Tests and Integration Tests #47

marc-antoine-girard opened this issue Jul 26, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@marc-antoine-girard
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It's getting hard to test every possible combination of things that can be achieved using SerializableInterface.

Describe the solution you'd like
It would be nice, eventually, to have tests. It would also make it easier to do PR (with automated tests and such)

Upside:

  • Having tests would prevent breaking changes
  • It would help better define what is possible to do
  • There could be test scenes to test inspector behaviour (if it's possible)
  • When there's going to be sample scenes, it would make sure they haven't been broken by some change

Downside:

  • Long / tedious to do
  • Dependency to Test Framework package

Describe alternatives you've considered
Manually check every possible combination of things that can happen every time a new PR is merged (or before). It doesn't quite scale well.

@Thundernerd Thundernerd added the help wanted Extra attention is needed label Aug 2, 2022
@Thundernerd
Copy link
Owner

It would indeed be nice to have. That said, I would not know how to approach this, as most of the functionality is provided visually through an inspector.

If anyone has solid ideas on how to approach this feel free to ping me.

@Thundernerd Thundernerd removed their assignment Aug 2, 2022
@marc-antoine-girard
Copy link
Contributor Author

I don't think unit testing the inspector is really feasible without going full reflection. This is mostly due to how Unity draws things in the inspector using IMGUI. That being said, I do believe it would be feasible if the drawing part was done using UI Toolkit and VisualElements, but that would be a major redesign of the backend code. On a side note, UI Toolkit is easier to customize tho...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants