Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use mp spawn mode for tests #263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cocolato
Copy link
Contributor

@cocolato cocolato commented Apr 18, 2024

Fix: #260

@cocolato
Copy link
Contributor Author

Maybe 3.6 testing should be skipped. I'm not sure if this implementation is what we want.

@aisk
Copy link
Member

aisk commented Apr 24, 2024

I think this approach is fine for me. But there are some tests that have been skipped because they require fork to start multiprocessing. So with this change, if this approach can solve the problem, we should enable these skipped tests to ensure that this change works as we expected.

For skipping the test on Windows with Python 3.6, I think maybe multiprocess does not support some functionalities on Windows with Python 3.6. So I'm fine with skipping it, but since it passed on Linux, I think we can modify the build.yaml to have it only skip on Windows with Python 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of using fork start method for mp module in the tests
2 participants