Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit offset explicitly when AutoCommit is disabled and added Test Code for Manual Commit #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

commit offset explicitly when AutoCommit is disabled and added Test Code for Manual Commit #25

wants to merge 2 commits into from

Conversation

tjnet
Copy link

@tjnet tjnet commented May 16, 2023 •
edited

context

I followed his suggestion

Can you add a test for that case in that file: https://github.com/ThreeDotsLabs/watermill-kafka/blob/master/pkg/kafka/pubsub_test.go

I think that it is not needed to run entire tests.TestPubSub. I think that it should be enough to use TestPublishSubscribe from the test suite.

could you confirm when you have time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tjnet