Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #192 | Adding a MessageUUIDHeaderKey configuration #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Agronis
Copy link

@Agronis Agronis commented Aug 4, 2020

Allows users of AMQP subscriber to not be bound to an upstream AMQP watermill publisher.

Reference ThreeDotsLabs/watermill#192

@roblaszczak
Copy link
Member

Hello @Agronis. To be honest I missed this PR (:man_facepalming:) and prepared mine (#4), which removes the requirement to have UUID in the message.

If you feel that auto-generation of UUID may be useful, you can align this PR to mine changes. My only suggestion will be:

  • ExpectMessageUUIDHeader - can probably describe better, that it will auto-generate message UUID
  • _, err := uuid.Parse(msgUUIDStr) - message UUID don't need to be a valid uuid! so you can remove that.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants