Issue305 | Add Topic Configurations #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? I think the Topology Builder change is quite necessary |
|
+1 on this, I would also like to see this change implemented. The current TopologyBuilder does not allow for wildcard matching on topic exchanges. |
|
Unfortunately, I no longer use amqp, which is why I'm not putting much effort into it at the moment. However, the merge is currently not down to me but to the lack of a review, if I can see that correctly. |
|
@m110 is it possible to get a review on this PR? I see no way currently with the package to use RabbitMQ topic exchanges with wildcard routing key matching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ThreeDotsLabs/watermill#305
Rework the TopologyBuilder to accept individual QueueBinding namings (TopologyBuilder Interface Change!)
Add configurations for topic routing
@m110 can you please review and approve this PR?