WP Ai Global Styles #1994
Merged
WP Ai Global Styles #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GunkaArtur
force-pushed
the
25691-wp-ai-global-styles
branch
from
bdcd3c5
to
96f7505
Compare
|
URL from config will be added here https://github.com/bagrinsergiu/blox-editor/issues/26071 |
GunkaArtur
force-pushed
the
25691-wp-ai-global-styles
branch
from
df9510c
to
a1ef05c
Compare
victor-pg
requested changes
Apr 18, 2024
|
|
||
| export const getAIGlobalStyles = (): AiGlobalStyles<Palette, FontStyle> => { | ||
| const apiUrl = | ||
| "https://phplaravel-1109775-4163586.cloudwaysapps.com/api/template"; |
There was a problem hiding this comment.
| return { | ||
| async getColors(res, rej) { | ||
| try { | ||
| const styles = await fetch(`${apiUrl}/style`).then((r) => r.json()); |
There was a problem hiding this comment.
use async/await without then:
const styles = await getStyles(/* ... */)| }, | ||
| async getTypography(res, rej) { | ||
| try { | ||
| const data = await fetch(`${apiUrl}/typography`).then((r) => r.json()); |
There was a problem hiding this comment.
here also use async/await without then
GunkaArtur
force-pushed
the
25691-wp-ai-global-styles
branch
from
9f38fc5
to
af88b4a
Compare
maxval1
requested changes
Apr 26, 2024
editor/editor/editor.php
Outdated
| @@ -93,6 +93,7 @@ public function getClientConfig($context) | |||
| 'project' => array( | |||
| 'status' => $this->getProjectStatus(), | |||
| ), | |||
| 'aiGlobalStyleUrl' => 'https://phplaravel-1109775-4163586.cloudwaysapps.com' | |||
| async getColors(res, rej) { | ||
| try { | ||
| const styles = await fetch( | ||
| `${aiGlobalStyleUrl}/api/template/style` |
GunkaArtur
force-pushed
the
25691-wp-ai-global-styles
branch
from
b2f388e
to
ad947b0
Compare
alecszaharia
added a commit
that referenced
this pull request
May 2, 2024
GunkaArtur
force-pushed
the
25691-wp-ai-global-styles
branch
2 times, most recently
from
3262ca7
to
7d60fd6
Compare
victor-pg
requested changes
May 8, 2024
|
|
||
| res(styles.colorPalette); | ||
| } catch (e) { | ||
| rej(t("Failed to load meta.json")); |
|
|
||
| res(data.fontStyles); | ||
| } catch (e) { | ||
| rej(t("Failed to load resolves for selected DefaultTemplate")); |
There was a problem hiding this comment.
review reject message
shouldn't be something like: "failed to load typography..." ?
| @@ -5,6 +5,15 @@ export interface DefaultBlock { | |||
| value: Record<string, unknown>; | |||
| } | |||
|
|
|||
| export interface AiGlobalStyles<T1, T2> { | |||
There was a problem hiding this comment.
rename AiGlobalStyles
as i see in previous @maxval1 review there is nothing with AI
public/editor-client/src/index.ts
Outdated
| set( | ||
| window.__VISUAL_CONFIG__.ui, | ||
| ["leftSidebar", "styles"], | ||
| getAIGlobalStyles(config) |
There was a problem hiding this comment.
rename also this function
GunkaArtur
force-pushed
the
25691-wp-ai-global-styles
branch
from
3671b4f
to
7c367b0
Compare
lift46252
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue https://github.com/bagrinsergiu/blox-editor/issues/25691