pages API #1986
Open
pages API #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GunkaArtur
force-pushed
the
25687-pagesAPI
branch
7 times, most recently
from
30eb203
to
d993631
Compare
maxval1
requested changes
Mar 25, 2024
brizy.php
Outdated
| @@ -17,7 +17,7 @@ | |||
| $_SERVER['HTTPS'] = 'on'; | |||
| } | |||
|
|
|||
| define('BRIZY_DEVELOPMENT', false ); | |||
| define('BRIZY_DEVELOPMENT', true ); | |||
public/editor-client/src/config.ts
Outdated
Comment on lines
103
to
112
| // pagesUrl: pipe( | ||
| // mPipe(Obj.readKey("pagesUrl"), Str.read), | ||
| // throwOnNullish("Invalid API Config: stories") | ||
| // ) |
There was a problem hiding this comment.
this will be in separate issue
Comment on lines
305
to
303
| const imageUrl = "https://cloud-1de12d.b-cdn.net/media/iW=1024&iH=1024/"; | ||
| const apiPagesUrl = "https://j6dfq8pl41.b-cdn.net/api"; |
There was a problem hiding this comment.
this will be in separate issue
Comment on lines
311
to
309
| const meta = await fetchAllLayouts<PagesAPI>( | ||
| `${apiPagesUrl}/get-pages`, | ||
| 50 | ||
| ); | ||
|
|
||
| res({ | ||
| blocks: convertPages(meta, imageUrl), | ||
| categories: getUniqueLayoutsCategories(meta) | ||
| }); |
There was a problem hiding this comment.
create the fn inside api folder same as savedLayouts
| ): Promise<T[]> => { | ||
| let allElements: T[] = []; | ||
|
|
||
| const firstPageResponse = await fetch(`${url}?per_page=${itemsPerPage}`).then( |
There was a problem hiding this comment.
the urls need to be create with makeUrl fn
GunkaArtur
force-pushed
the
25687-pagesAPI
branch
3 times, most recently
from
2e43940
to
cf0edb5
Compare
GunkaArtur
force-pushed
the
25687-pagesAPI
branch
3 times, most recently
from
49ee2d5
to
99b1b7e
Compare
GunkaArtur
force-pushed
the
25687-pagesAPI
branch
from
03c2607
to
fc6ef12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue https://github.com/bagrinsergiu/blox-editor/issues/25687