feat(ministry brands): handler in editor-client #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielGherjavca
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
from
f1d557f
to
5b88d8c
Compare
victor-pg
requested changes
Oct 31, 2023
| @@ -50,6 +51,12 @@ const api = { | |||
| searchCollectionItems, | |||
| getCollectionItemsIds | |||
| }, | |||
| modules: { | |||
There was a problem hiding this comment.
it is really need to be inside modules ?
beause is simple api handlers like handlers for Shopify
| import { Literal } from "utils/types"; | ||
| import { t } from "../utils/i18n"; | ||
|
|
||
| export const request = (url: string): Promise<EkklesiaResponse> => { |
There was a problem hiding this comment.
use request from editor-client/src/api/index.ts
| }; | ||
|
|
||
| export const fieldHaveParentsChildsKeys = ( | ||
| key: Record<string, Literal> | EkklesiaParentsChilds |
There was a problem hiding this comment.
maybe rename key in something like keys, because will be more readable and make short return
| return "childs" in key && "parents" in key; | ||
| }; | ||
|
|
||
| export const keysHaveSubkey = ( |
|
|
||
| export const getOption = ( | ||
| obj: Record<string, Literal> | undefined | ||
| ): ChoicesSync => { |
Comment on lines
36
to
38
| title: String(value), | ||
| value: key |
There was a problem hiding this comment.
key should not be on title ?
and better use string reader for instead of String(value)
There was a problem hiding this comment.
I receive response like this :
| export const getOption = ( | ||
| obj: Record<string, Literal> | undefined | ||
| ): ChoicesSync => { | ||
| return obj |
| ): Promise<ChoicesSync> => { | ||
| const { key } = keys; | ||
|
|
||
| const { data = {} } = await request(url.concat("?module=", key)); |
There was a problem hiding this comment.
instead of url.concat("?module=", key) use makeUrl function
There was a problem hiding this comment.
why file name is index.s.ts ?
DanielGherjavca
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
2 times, most recently
from
4617569
to
1ee8f47
Compare
DanielGherjavca
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
from
1ee8f47
to
b3d36fe
Compare
DanielGherjavca
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
from
b3d36fe
to
428debf
Compare
DanielGherjavca
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
2 times, most recently
from
952a694
to
436dcb3
Compare
ViorelEremia
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
from
436dcb3
to
27c021f
Compare
DanielGherjavca
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
2 times, most recently
from
39805ed
to
4285f11
Compare
DanielGherjavca
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
from
4285f11
to
d72af09
Compare
zeleniucvladislav
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
from
d72af09
to
2f209e3
Compare
DanielGherjavca
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
from
2f209e3
to
c0206f4
Compare
zeleniucvladislav
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
from
c0206f4
to
0f98999
Compare
added extra to updateEkklesiaFields
DanielGherjavca
force-pushed
the
24301-mb-move-handlers-in-editor-client
branch
from
0f98999
to
b555e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related : https://github.com/bagrinsergiu/blox-editor/issues/24301