Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving translations, adding OSM with link tc conf, some err fix #245

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

hubertgoeuropa
Copy link

PR fix some errors like:

  • creating chart error(comma instad dot in decimals)
  • some errors in mysql queries

@wkulesza
Copy link

@scrudden
additional comments to mysql fixes:
AvlJsonQuery.java - adding date_add to SQL, otherwise there was a syntax error for MySQL
ChartJsonBuilder.java - decimals were returned as ',' instead of '.'. Not Mysql, but this was handled.
SqlUtils.java - formatting the date for MySQL format.
schAdhByTimeData.jsp - deleting UNIX_TIMESTAMP for MySQL - there was a syntax error or no data was returned

@wkulesza
Copy link

@scrudden Sean, we will divide that PR into a couple PRs to make it easier for you to accept. We will add translations, you will migrate and then the remaining ones will follow.

@scrudden
Copy link
Member

scrudden commented Jul 22, 2021 via email

@@ -238,11 +238,11 @@ public String toString() {

// Add early/ontime/late info
if (temporalDifferenceMsec > 0)
str += " (early)";
str += " (wcześniej)";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this result in a Polish only string appearing somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants