Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iot factory webhook #93

Merged
merged 4 commits into from Feb 21, 2024
Merged

Conversation

loeliaM
Copy link
Contributor

@loeliaM loeliaM commented Jan 29, 2024

Summary

...

Changes

  • ...
  • ...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible, they don't break existing deployments.
  • Testing: The changes are tested.
  • Documentation: Relevant documentation is added or updated.

@github-actions github-actions bot added the needs/triage We still need to triage this label Jan 29, 2024
Copy link
Contributor

@nejraselimovic nejraselimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @loeliaM, first of all, thanks for contributing. Template looks good, but can you please remove the commented out parts? You also need to add your template to this file. Can you provide some blog post or documentation about connecting your platform to The Things Stack?

@nejraselimovic nejraselimovic removed the needs/triage We still need to triage this label Feb 4, 2024
iot-factory.yml Outdated
template-id: iot-factory
name: IoT Factory
description: Smart Metering & Asset Tracking
logo-url: https://iotfactory.eu/wp-content/uploads/2017/12/iot-factory-white.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @loeliaM, can you pls change the logo file so it's not white letters on transparent background? When we deploy the template, the page is white so these letters don't show, see on image below

image

@nejraselimovic nejraselimovic merged commit 11a3c1b into TheThingsNetwork:master Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants