Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximize Class A payload size #920

Merged
merged 3 commits into from Jul 4, 2019
Merged

Maximize Class A payload size #920

merged 3 commits into from Jul 4, 2019

Conversation

rvolosatovs
Copy link
Contributor

Summary

Closes #866

Changes

  • If both Rx1 and Rx2 are available, but payload fits only one of them - schedule only one of them

@rvolosatovs rvolosatovs added the c/network server This is related to the Network Server label Jul 3, 2019
@rvolosatovs rvolosatovs added this to the July 2019 milestone Jul 3, 2019
@rvolosatovs rvolosatovs self-assigned this Jul 3, 2019
@coveralls
Copy link

coveralls commented Jul 3, 2019 •
edited

Coverage Status

Coverage decreased (-0.001%) to 73.198% when pulling 5f1d799 on rvolosatovs:fix/downlink-size into 0b14d75 on TheThingsNetwork:master.

johanstokking
johanstokking approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also kudos for using a community bug report as test case

@rvolosatovs rvolosatovs merged commit 6d07533 into TheThingsNetwork:master Jul 4, 2019
@rvolosatovs rvolosatovs deleted the fix/downlink-size branch July 4, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking approved these changes

Assignees

@rvolosatovs rvolosatovs

Labels
c/network server This is related to the Network Server
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.

Consider Rx1 and Rx2 separately for max payload size
3 participants
@rvolosatovs @coveralls @johanstokking