Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit Packet Error Rate as part of the uplink messages #7048

Merged
merged 2 commits into from Apr 29, 2024

Conversation

adriansmares
Copy link
Contributor

Summary

References https://github.com/TheThingsIndustries/lorawan-stack/issues/4205

Changes

  • Add the packet error rate field to the API.
  • Fill in the packet error rate field while processing uplinks.

Testing

N/A. This is just a new API field which existing Network Server functionality which is already tested.

Regressions

N/A.

Notes for Reviewers

Writing the implementation explanation was longer than the actual 5 line implementation. Hence the PR.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.30.1 milestone Apr 25, 2024
@adriansmares adriansmares self-assigned this Apr 25, 2024
@github-actions github-actions bot added the c/network server This is related to the Network Server label Apr 25, 2024
@adriansmares adriansmares marked this pull request as ready for review April 25, 2024 15:31
@adriansmares adriansmares requested a review from a team as a code owner April 25, 2024 15:31
@adriansmares adriansmares merged commit 43a0e72 into v3.30 Apr 29, 2024
16 checks passed
@adriansmares adriansmares deleted the feature/4205-per branch April 29, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/network server This is related to the Network Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants