Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bookmarks panel to console overview #7016

Merged
merged 32 commits into from Apr 22, 2024

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Apr 2, 2024

Summary

This PR adds the top entities panel using bookmarks
Closes #6937
Closes #3968

Changes

  • Fix useBookmark hook
  • Fix toggle
  • Fix bookmarks dropdown
  • Add top entities panel
  • Add individual lists for the bookmark panel
  • Add bookmarks in the sidebar
  • Add fetching all the bookmarks
Screenshot 2024-04-15 at 12 45 49 Screenshot 2024-04-15 at 13 00 33 Screenshot 2024-04-15 at 13 19 43

Testing

To add a bookmark use dispatch(addBookmark(userId, {application_ids: { application_id: appId }}))

Notes for Reviewers

Todo:

  • Last activity leaving this for now. I can still come back to this before the MVP if I can manage to resolve all my other issues.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Apr 2, 2024
@ryaplots ryaplots self-assigned this Apr 2, 2024
Base automatically changed from feature/bookmarks-header to feature/console-redesign April 2, 2024 12:53
@ryaplots ryaplots marked this pull request as ready for review April 15, 2024 11:20
@ryaplots ryaplots requested a review from a team as a code owner April 15, 2024 11:20
@ryaplots ryaplots requested review from mjamescompton and kschiffer and removed request for a team April 15, 2024 11:20
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the sentence case comments, should have seen that earlier in the designs.

Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also experiencing one weird issue when using bookmark links:

  • Go to any application page
  • Now use the sidebar bookmark link to navigate to another application
  • You can now see only some of the info updating, such as the title and ID, however, all other info such as breadcrumb, device list, etc stays the same

@ryaplots
Copy link
Contributor Author

I solved this in a bit different way. We will need to fetch all the bookmarks in the overview either way because we need all of them in the sidebar. So in order to reduce the amount of fetches, we fetch all the bookmarks once in init.js. Then in the lists in the top entities we have a state of items which is filled from the store as the user scrolls. This way we only have one fetch of the bookmarks, at the same time we simulate the loading in chunks of 10, fetching the device count and lastActivity only when they are needed. @kschiffer

@ryaplots ryaplots requested a review from kschiffer April 21, 2024 14:46
@ryaplots ryaplots requested a review from kschiffer April 22, 2024 12:59
@ryaplots ryaplots merged commit 9948f35 into feature/console-redesign Apr 22, 2024
6 checks passed
@ryaplots ryaplots deleted the feature/bookmarks-panel branch April 22, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants