New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bookmarks panel to console overview #7016
Conversation
pkg/webui/console/containers/top-entities-dashboard-panel/top-applications/item.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the sentence case comments, should have seen that earlier in the designs.
pkg/webui/console/containers/sidebar/navigation/top-entities-section.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/top-entities-dashboard-panel/top-devices/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/top-entities-dashboard-panel/top-devices/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/top-entities-dashboard-panel/top-gateways/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/top-entities-dashboard-panel/top-gateways/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/top-entities-dashboard-panel/top-gateways/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also experiencing one weird issue when using bookmark links:
- Go to any application page
- Now use the sidebar bookmark link to navigate to another application
- You can now see only some of the info updating, such as the title and ID, however, all other info such as breadcrumb, device list, etc stays the same
pkg/webui/console/containers/top-entities-dashboard-panel/index.js
Outdated
Show resolved
Hide resolved
I solved this in a bit different way. We will need to fetch all the bookmarks in the overview either way because we need all of them in the sidebar. So in order to reduce the amount of fetches, we fetch all the bookmarks once in |
Summary
This PR adds the top entities panel using bookmarks
Closes #6937
Closes #3968
Changes
Testing
To add a bookmark use
dispatch(addBookmark(userId, {application_ids: { application_id: appId }}))
Notes for Reviewers
Todo:
Last activity
leaving this for now. I can still come back to this before the MVP if I can manage to resolve all my other issues.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.