Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proto deduplication does not extend indefinitely #5934

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

adriansmares
Copy link
Contributor

Summary

This PR ensures that our uplink deduplication script does not extend the metadata list indefinitely. This would happen because the TTL of the list accumulating the metadata is refreshed every time metadata is pushed, instead of being refreshed only on the first push.

Changes

  • Update the metadata list TTL only on the first push.
  • Remove some technical debt related to how we mock proto messages in Redis testing. We need to remove this for Migrate away from gogo/protobuf #2798 .

Testing

Unit tests and local testing.

Regressions

N/A.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the bug Something isn't working label Nov 11, 2022
@adriansmares adriansmares added this to the v3.23.0 milestone Nov 11, 2022
@adriansmares adriansmares self-assigned this Nov 11, 2022
@github-actions github-actions bot added the compat/db This could affect Database compatibility label Nov 11, 2022
@adriansmares adriansmares marked this pull request as ready for review November 11, 2022 14:33
@adriansmares adriansmares merged commit 2c9f186 into v3.23 Nov 14, 2022
@adriansmares adriansmares deleted the fix/redis-indefinite-buildup branch November 14, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compat/db This could affect Database compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants