cli: Fix login issues with explicit :443 port #3120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References #2965
Changes
Drop the explicit
:443
port number from the oauth server address if present.Testing
Test locally, with
http.redirect-to-tls
enabled and disabled. Login works as expected.Regressions
There should not be any, 443 is the default HTTPS port
Notes for Reviewers
This does not fix the issue on the server side, it only makes sure that the CLI does not suffer from it.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.