Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Fix login issues with explicit :443 port #3120

Merged
merged 1 commit into from Aug 24, 2020

Conversation

neoaggelos
Copy link
Contributor

Summary

References #2965

Changes

Drop the explicit :443 port number from the oauth server address if present.

Testing

Test locally, with http.redirect-to-tls enabled and disabled. Login works as expected.

Regressions

There should not be any, 443 is the default HTTPS port

Notes for Reviewers

This does not fix the issue on the server side, it only makes sure that the CLI does not suffer from it.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@neoaggelos neoaggelos added bug Something isn't working ui/cli This is related to ttn-lw-cli labels Aug 20, 2020
@neoaggelos neoaggelos added this to the August 2020 milestone Aug 20, 2020
@neoaggelos neoaggelos self-assigned this Aug 20, 2020
@github-actions github-actions bot added the documentation This involves writing user documentation label Aug 20, 2020
@neoaggelos neoaggelos force-pushed the fix/cli-ignore-port-443-for-oauth branch from c391c70 to a5612d7 Compare August 21, 2020 10:59
@neoaggelos neoaggelos merged commit 277642e into v3.9 Aug 24, 2020
@neoaggelos neoaggelos deleted the fix/cli-ignore-port-443-for-oauth branch August 24, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation This involves writing user documentation ui/cli This is related to ttn-lw-cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants