vendorProfileId #409
Merged
vendorProfileId #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrishnaIyer
reviewed
Apr 6, 2022
There was a problem hiding this comment.
@johanstokking: We are free to assign the vendorProfileID right? Should we follow some internal convention?
Just use linear numbers for each new profile?
Update in linear numbers
|
we can establish that 'vendorProfileId' should be filled linear instead of freely choice, what do you think? |
Ideally users can fill any valid value and we only check that it is unique for a given vendor. But if that's too complicated to validate, then I guess it's ok to make it linear. |
|
We can make this part of validation in CI. Can you file an issue @Jaime-Trinidad ? |
johanstokking
approved these changes
Apr 7, 2022
|
Yes I file an issue |
Bertje
pushed a commit
to ioTracker/lorawan-devices
that referenced
this pull request
Jun 16, 2022
* vendorProfileId * update vendorProfileId Update in linear numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add unique
vendorProfileIdto The Things Product and The Things Industries devices #405Changes
vendorProfileIdin each profile file, without repeating the IdNotes for Reviewers
...
Release Notes