Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing sensors and add device types #772

Merged
merged 25 commits into from May 2, 2024

Conversation

LDannijs
Copy link
Contributor

@LDannijs LDannijs commented Apr 8, 2024

Summary

Looked through the devices csv to note which devices are missing sensors. Was able to add it for a lot but Netvox, Radio Bridge and Tektelic have too many to manually change. Also added devicetype to compensate for devices with no sensors. Closes #769

Changes

  • Add missing sensors for a lot of devices missing them
    • EXCEPT Netvox, Radio Bridge and Tektelic (too many devices) and devices with no sensors (devicetype)
  • Add devicetype to the schema to identify what type of device it is
    • Some devices that don't have sensors now have devicetype to be able to filter for them.
  • Add devicetype to the csv script
  • Make images mandatory to add to device file
  • Remove The-box development and Grinn
    • No images for their devices, barren and old info, no information to be found about them online
  • fix Elvaco images

Notes for Reviewers

@Jaime-Trinidad lets discuss if this is correct and if there are things we're missing.

@LDannijs
Copy link
Contributor Author

LDannijs commented Apr 9, 2024

Decided to update Netvox, Radio bridge and Tektelic anyway :)

schema.json Outdated Show resolved Hide resolved
schema.json Outdated Show resolved Hide resolved
bin/csv.js Outdated Show resolved Hide resolved
@Jaime-Trinidad Jaime-Trinidad merged commit 3aa4c61 into TheThingsNetwork:master May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Sensors on Devices
3 participants