Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Sensors on Devices #769

Closed
Jaime-Trinidad opened this issue Apr 2, 2024 · 3 comments · Fixed by #772
Closed

Missing Sensors on Devices #769

Jaime-Trinidad opened this issue Apr 2, 2024 · 3 comments · Fixed by #772
Assignees
Milestone

Comments

@Jaime-Trinidad
Copy link
Contributor

Summary

There are 252 devices without sensors, it is needed to review if there is the need to add sensors that are not in .yaml file or contact device makers so they can add them. Also this will work for the dropdown menu

What do you see now?

252 devices without sensors in .yaml file

i.e. Elvaco cmi4130.yaml they deleted sensors

What do you want to see instead?

Reduce the number of devices without this information

How do you propose to implement this?

...

Can you do this yourself and submit a Pull Request?

@LDannijs let's work on this.

@github-actions github-actions bot added the needs/triage We still need to triage this label Apr 2, 2024
@KrishnaIyer KrishnaIyer removed the needs/triage We still need to triage this label Apr 9, 2024
@KrishnaIyer KrishnaIyer modified the milestones: Ape 2024, Apr 2024 Apr 9, 2024
@KrishnaIyer KrishnaIyer modified the milestones: Apr 2024, May 2024 May 2, 2024
@KrishnaIyer
Copy link
Member

@LDannijs: Can you pick this up in May?

@LDannijs
Copy link
Contributor

LDannijs commented May 2, 2024

@KrishnaIyer its already finished > #772 Just waiting for a merge. I'll send Jaime a message.

@KrishnaIyer
Copy link
Member

Awesome. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants