Support V2 API #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for module parameter Signed-off-by: Torbjørn Vatn <torbjorn.vatn@unacast.com> * Out path must be relative Signed-off-by: Torbjørn Vatn <torbjorn.vatn@unacast.com> * Add a short description to the README Signed-off-by: Torbjørn Vatn <torbjorn.vatn@unacast.com> * update other_package pkg and make to use module param Signed-off-by: Matthew Crenshaw <mcrenshaw@clearstreet.io> * fix make clean Signed-off-by: Matthew Crenshaw <mcrenshaw@clearstreet.io> Co-authored-by: Matthew Crenshaw <mcrenshaw@clearstreet.io>
bufbuild#459) * eliminates usage of old github.com/google/protobuf libraries, updates to google.golang.org/protobuf 1.5.2 Signed-off-by: Matthew Crenshaw <mcrenshaw@clearstreet.io> * fix remaining references Signed-off-by: Matthew Crenshaw <mcrenshaw@clearstreet.io> * make gazelle Signed-off-by: Matthew Crenshaw <mcrenshaw@clearstreet.io> * go mod tidy in tests Signed-off-by: Matthew Crenshaw <mcrenshaw@clearstreet.io> * go mod tidy in tests Signed-off-by: Matthew Crenshaw <mcrenshaw@clearstreet.io> * update Dockerfile Signed-off-by: Matthew Crenshaw <mcrenshaw@clearstreet.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References TheThingsNetwork/lorawan-stack#2798
This PR resets our fork of
protoc-gen-validateto the latest version of the0.5.1tag, replays the migration to the V2 proto API from upstream, and then introduces back our non-gogochanges.Changes
google.golang.org/protobufv1.28.1.protoc-gen-startov2.0.0-alpha1.