Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Bump noticed from 1.6.3 to 2.2.2 #4452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 23, 2024

Bumps noticed from 1.6.3 to 2.2.2.

Release notes

Sourced from noticed's releases.

v2.2.2

Full Changelog: excid3/noticed@v2.2.1...v2.2.2

v2.2.1

What's Changed

  • Support procs and symbol method calls with fetch_constant helpers
  • Use 'attributes[:params]' instead of 'params' in the example about migrating associated records in UPGRADE.md by @​drjole in excid3/noticed#427

New Contributors

Full Changelog: excid3/noticed@v2.2.0...v2.2.1

v2.2.0

What's Changed

New Contributors

Full Changelog: excid3/noticed@v2.1.3...v2.2.0

v2.1.3

Full Changelog: excid3/noticed@v2.1.2...v2.1.3

This release stringifies keys when sending Twilio Messaging notifications. Our docs show using Symbols for keys, but net/http wants them to be String. I'd prefer to support both, so this release adds compatibility for either or.

To use Twilio Messaging in previous versions, just set the keys to Strings instead.

v2.1.2

Full Changelog: excid3/noticed@v2.1.1...v2.1.2

v2.1.1

Full Changelog: excid3/noticed@v2.1.0...v2.1.1

... (truncated)

Changelog

Sourced from noticed's changelog.

2.2.2

  • fetch_constant will now constantize Strings returned from procs or method calls

2.2.1

  • fetch_constant used by Email and ActionCable delivery methods now support procs and method calls with symbols like other options

2.2.0

  • Add config.before_enqueue callback This callback can be used to skip enqueuing delivery methods:
class CommentNotifier < Noticed::Event
  deliver_by :email do |config|
    config.before_enqueue = ->{ throw(:abort) unless recipient.email_notifications? }
  end
end
  • Fix iOS format option with Symbols. This now passes the notification and apn objects instead of just the apn.
config.format = :ios_format
...
def ios_format(notification, apn)
end

  • Re-add deserialize_error? to Noticed::Event

2.1.3

  • Stringify keys for Twilio Messaging json

2.1.2

  • Fix counter cache migration version for older Rails

2.1.1

  • Fix duplicate column in migrations.
  • Add compatibility for apps that don't use ActionCable.

2.1.0

[!IMPORTANT] Run rails noticed:install:migrations to upgrade to this version

... (truncated)

Upgrade guide

Sourced from noticed's upgrade guide.

Noticed Upgrade Guide

Follow this guide to upgrade your Noticed implementation to the next version

Noticed 2.1

We've added a counter cache to Noticed::Event to keep track of the associated notifications.

Run the following command to copy over the migrations:

rails noticed:install:migrations

Noticed 2.0

We've made some major changes to Noticed to simplify and support more delivery methods.

Models

Instead of having models live in your application, Noticed v2 adds models managed by the gem.

Delete the Notification model at app/models/notification.rb.

Then run the new migrations:

rails noticed:install:migrations
rails db:migrate

To migrate your data to the new tables, loop through your existing notifications and create new records for each one. You can do this in a Rake task or in the Rails console:

# Temporarily define the Notification model to access the old table
class Notification < ActiveRecord::Base
  self.inheritance_column = nil
end
Migrate each record to the new tables
Notification.find_each do |notification|
attributes = notification.attributes.slice("type", "created_at", "updated_at").with_indifferent_access
attributes[:type] = attributes[:type].sub("Notification", "Notifier")
attributes[:params] = Noticed::Coder.load(notification.params)
attributes[:params] = {} if attributes[:params].try(:has_key?, "noticed_error") # Skip invalid records
Extract related record to belongs_to :record association
This allows ActiveRecord associations instead of querying the JSON data
attributes[:record] = attributes[:params].delete(:user) || attributes[:params].delete(:account)
attributes[:notifications_attributes] = [{
type: "#{attributes[:type]}::Notification",
</tr></table>

... (truncated)

Commits
  • 3333697 Version bump
  • bad2617 Standardize
  • 5d559b5 Constantize if proc/method returns a string for fetch_constant
  • beb4100 Merge branch 'main' of github.com:excid3/noticed
  • f200db6 Version bump
  • 8da57f8 Support method calls and procs with fetch_constant
  • a210447 Use 'attributes[:params]' instead of 'params' in the example about migrating ...
  • 5ccb422 Version bump
  • 2153397 Merge branch 'justwiebe-skip-enqueuing-job'
  • 12ce6a2 Refactor to before_enqueue callback
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Mar 23, 2024
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4452 March 27, 2024 07:56 Inactive
@dependabot dependabot bot force-pushed the dependabot/bundler/noticed-2.2.2 branch from 9436a64 to 902b44a Compare March 27, 2024 08:36
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4452 March 27, 2024 08:36 Inactive
@dependabot dependabot bot force-pushed the dependabot/bundler/noticed-2.2.2 branch from 902b44a to 618c6dc Compare March 27, 2024 08:37
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4452 March 27, 2024 08:37 Inactive
@KevinMulhern
Copy link
Member

@dependabot rebase

Bumps [noticed](https://github.com/excid3/noticed) from 1.6.3 to 2.2.2.
- [Release notes](https://github.com/excid3/noticed/releases)
- [Changelog](https://github.com/excid3/noticed/blob/main/CHANGELOG.md)
- [Upgrade guide](https://github.com/excid3/noticed/blob/main/UPGRADE.md)
- [Commits](excid3/noticed@v1.6.3...v2.2.2)

---
updated-dependencies:
- dependency-name: noticed
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/noticed-2.2.2 branch from 618c6dc to 7db10ce Compare April 22, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
Status: 📋 Backlog / Ideas
Development

Successfully merging this pull request may close these issues.

None yet

1 participant