Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Bump shakapacker from 6.6.0 to 7.0.2 #3944

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 10, 2023

Bumps shakapacker from 6.6.0 to 7.0.2.

Changelog

Sourced from shakapacker's changelog.

[v7.0.2] - July 3, 2023

Fixed

  • Fixed creation of assets:precompile if it is missing PR 325 by ahangarha.

[v7.0.1] - June 27, 2023

Fixed

  • Fixed the condition for showing warning for setting useContentHash to false in the production environment. PR 320 by ahangarha.

[v7.0.0] - June 23, 2023

Breaking changes

  • Removes defaults passed to @babel/preset-typescript. PR 273 by tomdracz.

    @babel/preset-typescript has been initialised in default configuration with { allExtensions: true, isTSX: true } - meaning every file in the codebase was treated as TSX leading to potential issues. This has been removed and returns to sensible default of the preset which is to figure out the file type from the extensions. This change might affect generated output however so it is marked as breaking.

  • Export immutable webpackConfig function. PR 293 by tomdracz.

    The webpackConfig property in the shakapacker module has been updated to be a function instead of a global mutable webpack configuration. This function now returns an immutable webpack configuration object, which ensures that any modifications made to it will not affect any other usage of the webpack configuration. If a project still requires the old mutable object, it can be accessed by replacing webpackConfig with globalMutableWebpackConfig. Check v7-upgrade documentation for more detail.

Added

  • Set CSS modules mode depending on file type. PR 261 by talyuk.
  • All standard webpack entries with the camelCase format are now supported in shakapacker.yml in snake_case format. PR276 by ahangarha.
  • The shakapacker:install rake task now has an option to force overriding files using FORCE=true environment variable PR311 by ahangarha.
  • Allow configuration of use of contentHash for specific environment PR 234 by justin808.

Changed

  • Rename Webpacker to Shakapacker in the entire project including config files, binstubs, environment variables, etc. with a high degree of backward compatibility.

    This change might be breaking for certain setups and edge cases. More information: v7 Upgrade Guide PR157 by ahangarha

  • Set source_entry_path to packs and nested_entries to true inshakapacker.yml PR 284 by ahangarha.

  • Dev server configuration is modified to follow webpack recommended configurations for dev server. PR276 by ahangarha:

    • Deprecated https entry is removed from the default configuration file, allowing to set server or https as per the project requirements. For more detail, check webpack documentation. The https entry can be effective only if there is no server entry in the config file.
    • allowed_hosts is now set to auto instead of all by default.
  • Remove the arbitrary stripping of the top-level directory when generating static file paths. PR 283 by tomdracz.

    Prior to this change, top level directory of static assets like images and fonts was stripped. This meant that file in app/javascript/images/image.png would be output to static/image.png directory and could be referenced through helpers as image_pack_tag("image.jpg") or image_pack_tag("static/image.jpg").

    Going forward, the top level directory of static files will be retained so this will necessitate the update of file name references in asset helpers. In the example above, the file sourced from app/javascript/images/image.png will be now output to static/images/image.png and needs to be referenced as image_pack_tag("images/image.jpg") or image_pack_tag("static/images/image.jpg").

Fixed

  • Move compilation lock file into the working directory. PR 272 by tomdracz.

  • Process source_entry_path with values starting with / as a relative path to source_path PR 284 by ahangarha.

  • Removes defaults passed to @babel/preset-typescript to make it possible to have projects with mix of JS and TS code PR 273 by tomdracz.

    @babel/preset-typescript has been initialised in default configuration with { allExtensions: true, isTSX: true } - meaning every file in the codebase was treated as TSX leading to potential issues. This has been removed and returns to sensible default of the preset which is to figure out the file type from the extensions. This change might affect generated output however so it is marked as breaking.

  • Fixed RC version detection during installation. PR312 by ahangarha

  • Fix addition of webpack-dev-server to devDependencies during installation. PR310 by ahangarha

Removed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jul 10, 2023
Bumps [shakapacker](https://github.com/shakacode/shakapacker) from 6.6.0 to 7.0.2.
- [Changelog](https://github.com/shakacode/shakapacker/blob/master/CHANGELOG.md)
- [Commits](shakacode/shakapacker@v6.6.0...v7.0.2)

---
updated-dependencies:
- dependency-name: shakapacker
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/shakapacker-7.0.2 branch from 3007f1c to 098780f Compare July 10, 2023 18:03
@KevinMulhern
Copy link
Member

Closing in favour of: #3946

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 10, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/bundler/shakapacker-7.0.2 branch July 10, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant