Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update lesson URLs for Advanced HTML/CSS course #2786

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Chore: update lesson URLs for Advanced HTML/CSS course #2786

merged 1 commit into from
Apr 11, 2022

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Mar 27, 2022 •
edited

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behaviour
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes

Complete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:

  • I have verified all tests and linters pass against my changes, and/or I have included automated tests where applicable

1. Because:

Related to:

  1. Cleaning up folder/file structure in the curriculum repository top-meta#109
  2. Add advanced_html_css folder curriculum#23899

2. This PR:

  1. Replace html_and_css_lessons.rb with advanced_html_and_css_lessons.rb & intermediate_html_and_css_lessons.rb
    • To be more inline with the course structure on the website.
  2. Update lesson urls of Advanced HTML/CSS course based on Add advanced_html_css folder curriculum#23899

3. Additional Information:

n/a

@01zulfi 01zulfi added Status: Needs Review This issue/PR needs an initial or additional review Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. Type: Epic This issue is a larger, unnamed project with several moving parts labels Mar 27, 2022
@KevinMulhern KevinMulhern temporarily deployed to odin-update-html-css-se-vsllax March 27, 2022 22:11 Inactive
@01zulfi 01zulfi added Status: Awaiting Changes Waiting for requested changes to be made by the contributor and removed Status: Needs Review This issue/PR needs an initial or additional review labels Mar 30, 2022
@01zulfi
update advanced html/css course lesson urls
c9bc2f9 
Because:
* changes in folder structure of the curriculum repository
@KevinMulhern KevinMulhern temporarily deployed to odin-update-html-css-se-vsllax March 30, 2022 13:25 Inactive
@01zulfi 01zulfi changed the title Chore: split html_and_css_lessons.rb & update lesson URLs for Advanced HTML/CSS course Chore: update lesson URLs for Advanced HTML/CSS course Mar 30, 2022
@KevinMulhern KevinMulhern temporarily deployed to odin-update-html-css-se-nf7but April 11, 2022 21:25 Inactive
KevinMulhern
KevinMulhern approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @01zulfi 💪

@KevinMulhern KevinMulhern merged commit 783f227 into TheOdinProject:main Apr 11, 2022
@01zulfi 01zulfi deleted the update-html-css-seeds branch April 14, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMulhern KevinMulhern KevinMulhern approved these changes

Assignees
No one assigned
Labels
Status: Awaiting Changes Waiting for requested changes to be made by the contributor Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. Type: Epic This issue is a larger, unnamed project with several moving parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@01zulfi @KevinMulhern