Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update rails lesson urls #2712

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Chore: update rails lesson urls #2712

merged 3 commits into from
Mar 22, 2022

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Mar 11, 2022 •
edited

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behaviour
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes

Complete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:

  • I have verified all tests and linters pass against my changes, and/or I have included automated tests where applicable

1. Because:

Related to:

  1. Cleaning up folder/file structure in the curriculum repository top-meta#109
  2. rails_programming: rename files & folders and move webpacker.md to archive curriculum#23760

2. This PR:

  1. Updates lesson urls of rails course based on rails_programming: rename files & folders and move webpacker.md to archive curriculum#23760

3. Additional Information:

n/a

@01zulfi 01zulfi added Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. Type: Epic This issue is a larger, unnamed project with several moving parts Status: Needs Review This issue/PR needs an initial or additional review labels Mar 11, 2022
@01zulfi
Copy link
Member Author

01zulfi commented Mar 14, 2022 •
edited

Replaced rails_programming with ruby_on_rails because of this: TheOdinProject/curriculum@68235e3

@KevinMulhern KevinMulhern temporarily deployed to odin-rails-cleanup-iz3gtp7f9bs March 20, 2022 14:18 Inactive
@KevinMulhern KevinMulhern temporarily deployed to odin-rails-cleanup-igoz3bo2wtq March 22, 2022 19:40 Inactive
KevinMulhern
KevinMulhern approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Thanks for doing this @01zulfi

@KevinMulhern KevinMulhern merged commit fa12cde into TheOdinProject:main Mar 22, 2022
@01zulfi 01zulfi deleted the rails-cleanup branch March 27, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMulhern KevinMulhern KevinMulhern approved these changes

@CouchofTomato CouchofTomato Awaiting requested review from CouchofTomato

Assignees
No one assigned
Labels
Status: Needs Review This issue/PR needs an initial or additional review Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. Type: Epic This issue is a larger, unnamed project with several moving parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@01zulfi @KevinMulhern @CouchofTomato