Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update lesson urls in getting_hired_lessons.rb #2688

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Chore: update lesson urls in getting_hired_lessons.rb #2688

merged 1 commit into from
Mar 3, 2022

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Mar 3, 2022 •
edited

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behaviour
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes

Complete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:

  • I have verified all tests and linters pass against my changes, and/or I have included automated tests where applicable

1. Because:

Related to:

  1. Cleaning up folder/file structure in the curriculum repository top-meta#109
  2. getting_hired: rename lessons & place them in appropriate folders based on the website  curriculum#23690

2. This PR:

  1. Updates lesson urls based on the changes in getting_hired: rename lessons & place them in appropriate folders based on the website  curriculum#23690

3. Additional Information:

n/a

@01zulfi
update lessons urls in getting_hired_lessons.rb
2cd4ec8 
- reason: lessons in the curriculum repository will either be moved into preparing_for_job_search folder or applying_and_interviewing
@01zulfi 01zulfi added Status: Needs Review This issue/PR needs an initial or additional review Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. labels Mar 3, 2022
@01zulfi 01zulfi added Type: Epic This issue is a larger, unnamed project with several moving parts and removed Status: Needs Review This issue/PR needs an initial or additional review labels Mar 3, 2022
@01zulfi 01zulfi merged commit 0f50a07 into TheOdinProject:main Mar 3, 2022
@01zulfi 01zulfi deleted the cleanup-getting-hired branch March 3, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CouchofTomato CouchofTomato CouchofTomato approved these changes

Assignees
No one assigned
Labels
Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. Type: Epic This issue is a larger, unnamed project with several moving parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@01zulfi @CouchofTomato