Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: auto-message on moderation message delete #247

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Sep 16, 2022

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage

Complete the following checkboxes ONLY IF they are applicable to your PR. You can complete them later if they are not currently applicable:

  • I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

1. Because:

Automating moderation actions is handy.

2. This PR:

Behaviour:

  1. Moderator+ are able to use a context menu command.
  2. Upon calling the command on the message (by right clicking it), the message gets deleted.
  3. User gets a DM.
  4. If DMs are off, users receive the auto-message in a private thread.

To Be Decided:

  1. Context menu command name
  2. Ephemeral message content
  3. Auto message content
  4. Thread name

3. Additional Information:

n/a

* Set up script to deploy new era commands
* Create 'Delete Message' context menu command
* Create ModerationMessageDelete service & utils for threads
* Fix points tests: botEngine.js wasn't mocked
* Update error handling for the case where can't send DMs to users
@wise-king-sullyman
Copy link
Member

@01zulfi I'll need to look into it more over the next couple days or so before I can really say what it will take to test this.

I won't block this PR for the tests so I've created #248 as a followup. If at all possible I would like to see it addressed before any more features are added in after this PR. Additionally, if you could create some followup issues for any tests needed for other recently added features that didn't include tests I would appreciate that.

@01zulfi 01zulfi merged commit 58de170 into main Oct 4, 2022
@01zulfi 01zulfi deleted the feat/message-delete branch March 22, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants