Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the order of appearance of padding, margin and border #27964

Merged
merged 2 commits into from
May 12, 2024

Conversation

RemanthManyam
Copy link
Contributor

@RemanthManyam RemanthManyam commented May 12, 2024

Because

The order of appearance of padding, margin and border is in order p-> m -> b which has now been changed to p -> b -> m. This was done to remove any confusions that may occur while reading those definitions as there is a chance of mix up

This PR

Small change

Issue

Closes #27947

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label May 12, 2024
@RemanthManyam RemanthManyam marked this pull request as draft May 12, 2024 06:03
@RemanthManyam RemanthManyam marked this pull request as ready for review May 12, 2024 06:16
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, and congrats on your first PR here!

@MaoShizhong MaoShizhong merged commit 606d695 into TheOdinProject:main May 12, 2024
3 checks passed
@RemanthManyam RemanthManyam deleted the box_model branch May 12, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Box Model: Small QOL improvment
2 participants