Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction to Express: Updated brad traversy express crash course.md #27963

Merged
merged 1 commit into from
May 13, 2024

Conversation

ReyHaider
Copy link
Contributor

updated the link to the upto date express crash course by brad traversy(traversy media).

Because

Traversy media has uploaded a new express crash course which is upto date. odin project linked to the older and outdated one. By updating this to the latest course, it can help people learn the newest stuff in express and avoid deprecated components.

This PR

  • Updated link to brad traversy express crash course.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

updated the link to the upto date express crash course by brad traversy(traversy media).
@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label May 11, 2024
@MaoShizhong
Copy link
Contributor

Thanks for opening this PR @ReyHaider. We already have an open issue on this #27865 which someone has already requested to be assigned to, and we request that PRs not be opened to fix something that's covered in an open issue. We're leaning towards not updating the link for that video for reasons detailed in that issue.

For now, I'll close this PR since if we do decide to update the link, we will be assigning the person who requested it in that issue.

@ReyHaider
Copy link
Contributor Author

Hi, Thank you for responding, I just wanted to clarify that the referred issue in your response is about updating nodeJs crash course while my PR was about updating the express crash course offered by traversy media, I did see that opened issue before sending a PR, and it did not contain any suggested changes related to intro to express section. Regards.

@MaoShizhong MaoShizhong reopened this May 13, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thank you for responding, I just wanted to clarify that the referred issue in your response is about updating nodeJs crash course while my PR was about updating the express crash course offered by traversy media, I did see that opened issue before sending a PR, and it did not contain any suggested changes related to intro to express section. Regards.

You are absolutely right and that is my mistake, so you have my sincere apologies!

We are actually in the process of updating our Node course, with the Express section being the current milestone, but we don't have a timeline set for when that will be released.

Just did a run through of the updated Express crash course and it still serves the curriculum purpose perfectly fine, where the Node crash course wasn't as justified in replacing the previous one in our context, so it won't hurt to update it while we still have this version of the lesson.

Thank you for making the suggestion, and sorry again for the mixup!

@MaoShizhong MaoShizhong merged commit 539ce01 into TheOdinProject:main May 13, 2024
4 checks passed
@ReyHaider
Copy link
Contributor Author

Thank you for considering my suggestion, it's a pleasure to contribute in anyway :).

@ReyHaider ReyHaider deleted the patch-1 branch May 13, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants