-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting: Update instructions for ESLint v9 #27939
Linting: Update instructions for ESLint v9 #27939
Conversation
@MaoShizhong There is a linting error about a missing heading for I have assumed that it is fine to ignore in this case. |
@gingkapls You can ignore the assignment linting error for the moment. Putting this on hold while investigating further things regarding the ESLint extension, and flat config rules, as it seems we might need to tweak some stuff due to confusion new systems. |
@MaoShizhong eslint-plugin-react does not work with eslint v9 yet, and since Vite pulls it in as a dependency, it too defaults to using ESLint v8 and the older This creates a discrepancy between the instructions in the Linting lesson and the ones in Setting Up a React Environment where we suggest using I think the instructions in the React lesson will have to remain the same until Vite updates to ESLint v9, but I haven't reached the React section of the curriculum myself so I cannot give any further input on the impact of the discrepancy between the two lessons. |
@gingkapls Thanks for looking into that. I just came across the same thing regarding some non-curriculum options, which will be resolved once the necessary plugins support v9+. For now, I'm not concerned about the React part. The linting lesson is about introducing Linters and getting started with ESLint. In the React portion, all the necessary deps and files are generated when you run the Vite CLI command, so it does everything for you. The only difference will be the eslint config won't use the flat config format (which will be fine pre-v9). Vite will update their create CLI tool for the React template once they are able to (which will likely be when `eslint-plugin. We actually do not need that
So that part can actually be removed, but the rest of the React set up lesson can remain as is. |
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything else should be good to go, just the one small "might as well" below. Thank you for looking into and working on this as well. Not easy when the tool's release itself wasn't the cleanest...
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
It was a fun experience, and I got to help out too. Thanks for helping and guiding me throughout all this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Will keep an eye on the ESLint extension for changes to releases and any settings.
Because
The recent ESLint V9 update made breaking changes to the default configuration file format, which resulted in the old instructions becoming out-of-date and some plugins to stop working with the new default format among other changes.
This PR
Issue
Closes #27818
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section